Fix shim crash when cleaning up process-isolated containers #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
|
LGTM. Thanks for the contribution! |
jterry75
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was observed while experimenting with Buildkit for Windows against containerd, and getting a 'ttrpc closed' error after the layer had completed its task successfully.
The null ptr access in
vm.DeleteContainerStateSupportedwas killing the thread it was on, and hence the channel back to containerd was never given an answer before the shim cleaned up the container and terminated.